Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster faction shenanigans #72722

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Monster faction shenanigans #72722

merged 4 commits into from
Mar 31, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

Noticed some weirdness in our monster factions and wanted to correct them

Describe the solution

  • Split domestic and wild herbivores - they really don't often play on the same teams irl, and since a lot of herbivores have triggers related to friends being hurt, I think it warrants these two being split
  • Moved the dambreaker from small_animal to herbivore, as the normal beaver is there and dambreakers are larger
  • Moved the ladybug larva from the default insect faction into the same faction as its parents - also corrected the spelling in its name while I was here
  • Added a new faction for small dogs - currently only has the chihuahua. This was done so that more predators can want to actually kill those little assholes, while zombies ignore them (as they're supposed to, given how tiny chihuahuas are - them zombifying is a separate issue)

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Mar 30, 2024
@Karol1223 Karol1223 changed the title Faction shenanigans Monster faction shenanigans Mar 30, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 30, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 30, 2024
@Maleclypse Maleclypse merged commit d8a6818 into CleverRaven:master Mar 31, 2024
20 of 24 checks passed
@Karol1223 Karol1223 deleted the factions branch March 31, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants